Redirect users to the consent options page if consent is needed.

Review Request #9943 — Created May 15, 2018 and submitted

Information

Review Board
release-3.0.x
9def0b8...

Reviewers

This updates the @valid_prefs_required decorator to also check to see
whether any consent requirements need to be decided upon by the user. If
so, they're redirected to the My Account page to provide consent. This
will happen any time there's a consent requirement that the user has not
decided upon.

Many of the views in Review Board didn't have this decorator (or its
mixin equivalent) applied, so I've also gone through and added it to any
pages that were relevant.

Unit tests pass.

Manually tested with the global option enabled/disabled.

Manually tested with no consent options provided, only some provided,
and all provided.

Description From Last Updated

F401 'djblets.privacy.consent.get_consent_requirements_registry' imported but unused

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.0.x (6d3882c)