Summary

Add a specialized version of the new siteconfig_settings test utility.

Review Request #9942 — Created May 15, 2018 and submitted May 15, 2018, 5:28 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

~~9941~~

Commit

30b5415...

Reviewers

Groups

reviewboard

People

Description

This overrides the new TestCase.siteconfig_settings from Djblets,
adding the optional (but on by default) ability the reload settings from
the siteconfig after adding the new settings and then after reverting
them.

Some existing tests making use of an internal version of this utility
have been updated to use the new one on the base testcase.

Testing Done

Unit tests pass.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Change Summary:


Added missing docs.
Renamed the apply_settings parameter to reload_settings.

Commit:

7bd2d0eb3811e1322f5203be6655e748e801af2f

07976b4df87c68983b49ef99b8c658b9ea5959b9

Diff:

Revision 2 (+33 -35)

Show changes

	reviewboard/extensions/tests.py
	reviewboard/testing/testcase.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Added a missing change to a file doing an import, which got rolled up into another change.

Commit:

07976b4df87c68983b49ef99b8c658b9ea5959b9

30b5415b4f9b3b9e2f3cf78ff30b61bf1702e442

Diff:

Revision 3 (+34 -37)

Show changes

	reviewboard/accounts/tests.py
	reviewboard/extensions/tests.py
	reviewboard/testing/testcase.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (101db06)