• 
      

    Don't validate fields when publishing from the set-submitted hook.

    Review Request #9916 — Created May 8, 2018 and submitted — Latest diff uploaded

    Information

    Review Board
    release-3.0.x
    450b268...

    Reviewers

    Recently I've seen some errors go by that are triggered by the
    set-submitted webhook endpoint. In this case, a review request was
    created for the linked review request but never had reviewers added, and
    it was never published. Once the change itself is pushed, we want to
    mark the change as submitted, but that first requires publishing it. The
    recent change that moved field validation to the server side was
    interfering with this.

    This change adds a bit of plumbing to allow the webhook endpoint to turn
    off field validation, since at this point we really don't care about it
    anymore. I've also changed it so that it won't send an e-mail when
    publishing from the hook.

    • Triggered the webhook endpoint.
    • Ran unit tests.