• 
      

    Review request policy fix: private repo users should have access even if review request has target groups

    Review Request #9908 — Created May 3, 2018 and discarded — Latest diff uploaded

    Information

    pc
    Review Board
    release-3.0.x

    Reviewers

    As per the docs (and relevant docstring), users who can access private repositories can also access its private review requests. This works fine, until an invite-only review group is added to the review request. This patch fixes and tests for the bug.

    Access Control docs:

    Review Request Access Summary
    To summarize, a user has access to a review request only if all the following conditions are met:
     ...
     * The repository is public or the user has access to to it (either by being explicitly on the user access list, or by being a member of a group on that list).
     ...
    

    PS. I recommend reviewing the raw or expanded diff, as reviewboard has made the visual diff below very jumbled

    Test cases in patch pass.