Summary

Review request policy fix: private repo users should have access even if review request has target groups

Review Request #9908 — Created May 3, 2018 and discarded Sept. 14, 2021, 11:17 p.m.

Information

Owner

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

As per the docs (and relevant docstring), users who can access private repositories can also access its private review requests. This works fine, until an invite-only review group is added to the review request. This patch fixes and tests for the bug.
Access Control docs:
Review Request Access Summary
To summarize, a user has access to a review request only if all the following conditions are met:
 ...
 * The repository is public or the user has access to to it (either by being explicitly on the user access list, or by being a member of a group on that list).
 ...


PS. I recommend reviewing the raw or expanded diff, as reviewboard has made the visual diff below very jumbled

Testing Done

Test cases in patch pass.

Issues

Description	From	Last Updated
E501 line too long (83 > 79 characters)	reviewbot	May 3, 2018, 3:30 a.m.
E501 line too long (83 > 79 characters)	reviewbot	May 3, 2018, 3:30 a.m.
E501 line too long (85 > 79 characters)	reviewbot	May 3, 2018, 3:30 a.m.
E501 line too long (80 > 79 characters)	reviewbot	May 3, 2018, 3:30 a.m.
E501 line too long (91 > 79 characters)	reviewbot	May 3, 2018, 3:30 a.m.
E501 line too long (83 > 79 characters)	reviewbot	May 3, 2018, 3:30 a.m.
E501 line too long (87 > 79 characters)	reviewbot	May 3, 2018, 3:30 a.m.
E501 line too long (83 > 79 characters)	reviewbot	May 3, 2018, 3:30 a.m.
E501 line too long (91 > 79 characters)	reviewbot	May 3, 2018, 3:30 a.m.
E501 line too long (83 > 79 characters)	reviewbot	May 3, 2018, 3:30 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/models/review_request.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (83 > 79 characters)
```
reviewboard/reviews/tests/test_policy.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (83 > 79 characters)
```
reviewboard/reviews/tests/test_policy.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (85 > 79 characters)
```
reviewboard/reviews/tests/test_policy.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/reviews/tests/test_policy.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (91 > 79 characters)
```
reviewboard/reviews/tests/test_policy.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (83 > 79 characters)
```
reviewboard/reviews/tests/test_policy.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (87 > 79 characters)
```
reviewboard/reviews/tests/test_policy.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (83 > 79 characters)
```
reviewboard/reviews/tests/test_policy.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (91 > 79 characters)
```
reviewboard/reviews/tests/test_policy.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (83 > 79 characters)
```

Status:: Discarded