Summary

Add a DVCS capability gated behind the DVCS feature

Review Request #9905 — Created May 2, 2018 and submitted Aug. 29, 2018, 12:26 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

~~9889~~

Blocks

9920

Commit

6503100...

Reviewers

Groups

reviewboard

People

Description

We now have the review_request.supports_history capability, which is
only present when the dvcs feature is enabled. When disabled, this
capability does not appear in the set of capabilities at all.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Typo in the first line of the description: "hte" -> "the"	chipx86	July 5, 2018, 2:32 p.m.
"HTTP"	chipx86	July 5, 2018, 2:32 p.m.
This isn't what this returns. It yields tuples. Should we have it yield dicts?	chipx86	Aug. 23, 2018, 4:25 p.m.
Typo: "capabilties" -> "capabilities"	chipx86	Aug. 23, 2018, 4:25 p.m.

flake8 passed.

JSHint passed.

Ship it!

The issue has been resolved. Show all issues

Typo in the first line of the description: "hte" -> "the"

reviewboard/webapi/server_info.py (Diff revision 1)
The issue has been resolved. Show all issues
```
"HTTP"
```

Change Summary:

Addressed issues

Description:

~		We now have hte `review_request.supports_history` capability, which is
	~	We now have the `review_request.supports_history` capability, which is
		only present when the dvcs feature is enabled. When disabled, this
		capability does not appear in the set of capabilities at all.

Commit:

2091674b611fc183807515e3a3b2adf49ad17876

939d9f2e49255d32099a8d895cf2778de2df4f60

Diff:

Revision 2 (+70 -3)

Show changes

	reviewboard/webapi/server_info.py
	reviewboard/webapi/tests/test_root.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/webapi/server_info.py (Diff revision 2)

The issue has been resolved. Show all issues

This isn't what this returns. It yields tuples.

Should we have it yield dicts?

reviewboard/webapi/server_info.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Typo: "capabilties" -> "capabilities"
```

Change Summary:

Addressed Christian's comments

Commit:

939d9f2e49255d32099a8d895cf2778de2df4f60

6503100792a2d594144fc526089988e60fa25cef

Diff:

Revision 3 (+75 -4)

Show changes

	reviewboard/webapi/server_info.py
	reviewboard/webapi/tests/test_root.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (96d16e4)