Summary

Fix FileNotFoundError invocation in Git SCMTool

Review Request #9901 — Created May 2, 2018 and submitted May 10, 2018, 8:57 p.m.

Owner

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

ffff95e...

Groups

People

Description

The Git SCMTool was providing the commit SHA to the FileNotFoundError,
leading to misleading error messages. This has been fixed.

Testing Done

Triggered a FileNotFoundError in a Git repository and saw the correct
error message.

Issues

Description	From	Last Updated
How about FileNotFoundError(path, revision=commit)?	david	May 10, 2018, 2 p.m.

flake8 passed.

JSHint passed.

reviewboard/scmtools/git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
How about FileNotFoundError(path, revision=commit)?
```

Change Summary:

Addressed David's feedback.

Commit:

aa814e62acff31d130aa643b7b7c2af3ffce6e64

ffff95ee8458b8dbafae58dabe446da6cb53fdd0

Diff:

flake8 passed.

JSHint passed.

Ship it!

reviewboard/scmtools/git.py (Diff revision 1)