Summary

Make unit tests more resilient with regards to working directory.

Review Request #9895 — Created April 26, 2018 and submitted June 4, 2018, 8:41 p.m.

Information

Owner

david

Repository

RBTools

Branch

release-1.0.x

Bugs

Depends On

Commit

13a3c27...

Reviewers

Groups

People

Description

In some cases, a test failure in a test that changes the working
directory or $HOME in some way would cause all following tests to
fail. This change fixes up various issues that could cause that kind of
pollution, along with some other related tempdir and reviewboardrc
cleanups.

Based on work by Joshua Olson at https://reviews.reviewboard.org/r/9654/

Testing Done

Ran unit tests on Python 2.7 and 3.6

Issues

Description	From	Last Updated
E501 line too long (83 > 79 characters)	reviewbot	April 26, 2018, 6:36 p.m.
cwde isn't documented.	chipx86	May 1, 2018, 1:14 a.m.

flake8 failed.

JSHint passed.

flake8

rbtools/clients/tests/test_bzr.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (83 > 79 characters)
```

Commit:

6036b6fb5f93d76316c9bdfb98c9f2dc9f57531a

d6db703848c64d2d5f22ec2e5f644a37093dacc1

Diff:

Revision 2 (+87 -68)

	rbtools/clients/tests/test_bzr.py
	rbtools/clients/tests/test_git.py
	rbtools/clients/tests/test_mercurial.py
	rbtools/utils/testbase.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/clients/tests/test_bzr.py (Diff revision 2)
The issue has been resolved. Show all issues
```
cwde isn't documented.
```

Commit:

d6db703848c64d2d5f22ec2e5f644a37093dacc1

13a3c2700368b7ce35583695e7622e0e50dcab21

Diff:

Revision 3 (+90 -68)

	rbtools/clients/tests/test_bzr.py
	rbtools/clients/tests/test_git.py
	rbtools/clients/tests/test_mercurial.py
	rbtools/utils/testbase.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.0.x (df22b66)