Summary

Explain what profile information is kept private

Review Request #9888 — Created April 23, 2018 and submitted May 1, 2018, 2:35 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

~~9887~~

Commit

6102f83...

Reviewers

Groups

reviewboard

People

Description

This change adds help text to the "Keep profile information private"

setting in the "My Account", explaining exactly what information is kept

private and from whom.

Testing Done

Viewed the my account page.

Files

Issues

Description	From	Last Updated
"timezone information" is weird. How about just "timezone"	david	April 24, 2018, 11:36 a.m.
We say "Profile information ... hidden" an awful lot, I realized, making this verbose. How about: By default, profile information …	chipx86	April 30, 2018, 1:54 p.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

reviewboard/accounts/forms/pages.py (Diff revision 1)
The issue has been resolved. Show all issues
```
"timezone information" is weird. How about just "timezone"
```

Commit:

26f9424e9c15cbef5990dc5c143c40b7fbbb120a

a813cc44790b256f40bbdb3db4684f05f752e826

Diff:

Revision 2 (+11 -1)

Show changes

	reviewboard/accounts/forms/pages.py
	reviewboard/static/rb/css/pages/my-account.less

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

reviewboard/accounts/forms/pages.py (Diff revision 2)

The issue has been resolved. Show all issues

We say "Profile information ... hidden" an awful lot, I realized, making this verbose. How about:

By default, profile information (full name, e-mail address, and timezone) is only hidden from users who are not logged in. With this setting enabled, it will also be hidden from all non-administrators.

Change Summary:

Addressed feedback.

Commit:

a813cc44790b256f40bbdb3db4684f05f752e826

6102f83b1d1d53b2c3162038a6a22463a135a209

Diff:

Revision 3 (+10 -1)

Show changes

	reviewboard/accounts/forms/pages.py
	reviewboard/static/rb/css/pages/my-account.less

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status:: Completed
Change Summary:: Pushed to release-3.0.x (b894e38)