flake8
passed.
JSHint
passed.
Hide profile information from anonymous users
Review Request #9887 — Created April 23, 2018 and submitted
Previously, public profile information was available to anonymous users.
Now we limit public profile information to authenticated users only. If
a user marks their profile as private nothing has changed and it will
still not be visible to authenticated users (except for themselves and
staff). User infoboxes now use the updated logic so the same information
is visible.While I was here I cleaned up the other profile test docstrings.
To make things consistent for LocalSites, LocalSite admins can now view
private profiles of their LocalSite members.
Ran unit tests.
Viewed a public profile while logged out and saw no profile information
aside from username.Viewed a userbox for a user with a public profile and only saw their
username.
| Description | From | Last Updated |
|---|---|---|
|
Also needs the following tests: None user Local Site team member with public profile Local Site team member with private … |
 chipx86
|
|
|
"Otherwise" doesn't sound right here. I'd say "For authenticated users, ..." |
chipx86
|
|
|
If we can check not_private first, that'll save us a possible query. |
chipx86
|
|
|
"Testing" and "LocalSite" |
chipx86
|
|
|
"Testing" and "LocalSite" |
chipx86
|
|
|
"LocalSite" |
chipx86
|
|
|
"LocalSite" |
chipx86
|
|
|
Let's also assert the values from each of these. |
chipx86
|
- Change Summary:
-
Post all the changes!
- Commit:
-
498fc85d8e25fad970445bbd7a03021a342b951ae2b765a646df5e1eb6461a44de3073751f27257a
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Change Summary:
-
Addressed Christian's feedback.
- Description:
-
Previously, public profile information was available to anonymous users.
Now we limit public profile information to authenticated users only. If a user marks their profile as private nothing has changed and it will still not be visible to authenticated users (except for themselves and staff). User infoboxes now use the updated logic so the same information is visible. While I was here I cleaned up the other profile test docstrings.
+ + To make things consistent for LocalSites, LocalSite admins can now view
+ private profiles of their LocalSite members. - Commit:
-
e2b765a646df5e1eb6461a44de3073751f27257a3d66ae20c6ddae7de8bc0ee24be1b5375092cd60
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Change Summary:
-
Addressed Christian's issues.
- Commit:
-
3d66ae20c6ddae7de8bc0ee24be1b5375092cd60b0a04aefc5db72ed5ab5213133a53c8deaf1e4e8
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Change Summary:
-
Addressed feedback.
- Commit:
-
b0a04aefc5db72ed5ab5213133a53c8deaf1e4e854ab72ec418468d3280e084c5f3ad694c156d3b9
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Change Summary:
-
Fix failing unit test, add another
- Commit:
-
54ab72ec418468d3280e084c5f3ad694c156d3b98e24a426fb4701612978874851fc1c400dc7d0fc
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Change Summary:
-
Remove debug code.
- Commit:
-
8e24a426fb4701612978874851fc1c400dc7d0fc89e7fd009c1e9287df6d564feb7ed30eb8edc2b4
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Change Summary:
-
For real tho.
- Commit:
-
89e7fd009c1e9287df6d564feb7ed30eb8edc2b4399fa268288d3ab6d22c908fe557804df9f40c4f
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.