Port rb-gateway to go-git.

 






 

 


  Review Request #9875
  —
  Created April 16, 2018 and submitted 

 


















 

  

   Information

  





 
 

  david
 









 
 

  rb-gateway
 









 
 

  master
 









 
 

  
 









 
 

  
 









 
 

  58e12b4...
 






 




 

  

   Reviewers

  





 
 

  rb-gateway
 









 
 

  
 






 








 





  


 
 

  
The libgit2-based git2go is a decent API, but it's a pain to deal with.

It needs very specific versions of libgit2 to be installed, and makes it

very hard to cross-compile or distribute binaries that link against it.

This change ports rb-gateway to the go-git library, which is a pure Go

implementation with a very similar API to git2go.

 








  


 
 

  
    

  • Ran unit tests
    • 

  • Tested post-commit review request creation and diff viewing with
    
  Review Board.
    • 


 







 









 





  








 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
dep lets us use github directly, so we can just have github.com/src-d/go-git and the version=4.2.1 line will pick the right …

      		
      
       brenniebrennie
      
      
       
      
     


    
   

  

 







 






  

 



















 




 




 














 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Looks fine to me, but might be good to get another pair of eyes on this.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




brennie




   

   









  

 



 

  


   

   

    
 
brennie


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       Gopkg.toml
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    dep lets us use github directly, so we can just have github.com/src-d/go-git and the version=4.2.1 line will pick the right tag to use.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Something about the layout of the code in their github repo is confusing dep. Not sure why but for now I'm just going to keep going with their recommendation of the gopkg URL.
      
 
      

      2. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Completed

   

  




  

   

    Change Summary:
   

   

    
Pushed to master (708632f)