Summary

Port rb-gateway to go-git.

Review Request #9875 — Created April 16, 2018 and submitted June 4, 2018, 3:37 p.m.

Information

Owner

david

Repository

rb-gateway

Branch

master

Bugs

Depends On

Commit

58e12b4...

Reviewers

Groups

rb-gateway

People

Description

The libgit2-based git2go is a decent API, but it's a pain to deal with.
It needs very specific versions of libgit2 to be installed, and makes it
very hard to cross-compile or distribute binaries that link against it.
This change ports rb-gateway to the go-git library, which is a pure Go
implementation with a very similar API to git2go.

Testing Done


Ran unit tests
Tested post-commit review request creation and diff viewing with

  Review Board.

Issues

Description	From	Last Updated
dep lets us use github directly, so we can just have github.com/src-d/go-git and the version=4.2.1 line will pick the right …	brennie	June 4, 2018, 3:33 p.m.

flake8 passed.

JSHint passed.

Ship it!

Looks fine to me, but might be good to get another pair of eyes on this.

Ship it!

Gopkg.toml (Diff revision 1)

The issue has been dropped. Show all issues

dep lets us use github directly, so we can just have github.com/src-d/go-git and the version=4.2.1 line will pick the right tag to use.

david June 4, 2018, 3:33 p.m.

Something about the layout of the code in their github repo is confusing dep. Not sure why but for now I'm just going to keep going with their recommendation of the gopkg URL.

Status:: Completed
Change Summary:: Pushed to master (708632f)