Fix redirecting from the root of a local site.
Review Request #9845 — Created March 29, 2018 and submitted — Latest diff uploaded
RootView
was using a legacy variable to redirect from the root of
Local Site. While this wasn't as big a problem on standalone Review
Board servers (it would end up redirecting to a non-Local Site URL), it
outright crashed RBCommons.The proper variable for the Local Site is now used. Unit tests were
added to check for regressions. These uncovered an old query argument
used for login redirects, which no longer works. That query argument was
updated.
Unit tests pass.
Manually tested the redirects and that the old query argument didn't
work but the new one does.