Fix crashes when using "submit-as" with Active Directory.

Review Request #9821 — Created March 22, 2018 and submitted

Information

Review Board
release-3.0.x
28c8bbf...

Reviewers

When using the "submit-as" option when posting a review request, it
tries to call get_or_create_user() for each auth backend. Some of
these implementations accept optional arguments, but Active Directory
makes its optional arguments required, causing crashes.

This change makes the parameter truly optional and bails if it's needed
but not provided.

Unit tests pass.

david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.0.x (23411ae)