• 
      

    MOVED Extracted serialization code out of WebAPIResponse

    Review Request #982 — Created Aug. 21, 2009 and discarded

    Information

    Navi (deprecated)
    serialization

    Reviewers

    MOVED:
    This review request is now at: http://reviews.review-board.org/r/1083/
    
    This stuff can be reused in other pure serialization contexts (namely, webhook payloads), not only in HTTP responses.
    Ran ReviewBoard test suite with it, passed all tests.
    chipx86
    1. 
        
    2. /trunk/djblets/djblets/webapi/core.py (Diff revision 1)
       
       
      Please add a documentation block explaining this class.
    3. /trunk/djblets/djblets/webapi/core.py (Diff revision 1)
       
       
       
       
      Two blank lines between classes.
    4. /trunk/djblets/djblets/webapi/core.py (Diff revision 1)
       
       
      pass should be on its own line.
    5. /trunk/djblets/djblets/webapi/core.py (Diff revision 1)
       
       
       
       
      No blank line here.
    6. /trunk/djblets/djblets/webapi/core.py (Diff revision 1)
       
       
      Should pass the format as a parameter.
    7. 
        
    HE
    1. 
        
    2. /trunk/djblets/djblets/webapi/core.py (Diff revision 1)
       
       
       
       
      Ok. There were some other class docstrings with blank lines after them, so I removed those too.
    3. 
        
    HE
    HE
    Review request changed
    Change Summary:
    MOVED.
    Summary:
    Extracted serialization code out of WebAPIResponse
    MOVED Extracted serialization code out of WebAPIResponse
    Description:
      +

    MOVED:

      + This review request is now at: http://reviews.review-board.org/r/1083/

      +
       

    This stuff can be reused in other pure serialization contexts (namely, webhook payloads), not only in HTTP responses.