• 
      

    Fix some bad checks in hosting service tests and bullet-proof others.

    Review Request #9791 — Created March 15, 2018 and submitted — Latest diff uploaded

    Information

    Review Board
    release-3.0.x
    e761a04...

    Reviewers

    We had a handful of copy/pasted checks in hosting services that either
    weren't properly checking for the data in responses fully, or were
    checking incorrectly. This change attempts to bullet-proof many of our
    checks full responses (commits to commits or dicts to dicts) instead of
    partial responses (just specific attributes/keys of objects), and fixes
    the commit checks to specifically compare diffs (which aren't taken into
    consideration during equality checks).

    Unit tests pass.