flake8
passed.
JSHint
passed.
chipx86 got a fish trophy!
Update the Beanstalk tests to use the new hosting service test helpers.
Review Request #9779 — Created March 14, 2018 and submitted
This updates the Beanstalk test suite to use the new helpers for hosting
service unit tests, which provide better, more consistent checks with
simpler code. The results of all HTTP requests are checked, ensuring
we're calling what we expect and that behavior doesn't change in the
future.
Unit tests pass.
- Change Summary:
-
Added missing docstrings.
- Commit:
-
e8918d55323a95fe61cfc928ae9dfc8ca1967695fa1394fef737463c67089f15facf82caf3d9e4b9
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Change Summary:
-
Rebuilt this change to use the new hosting service test architecture.
- Summary:
-
Update the Beanstalk tests for better checks and to meet standards.Update the Beanstalk tests to use the new hosting service test helpers.
- Description:
-
~ This updates the Beanstalk test suite to check all the HTTP requests
~ performed, ensuring that we're calling each API we expect with the ~ correct data in the correct order, and to ensure that payloads are sent ~ as bytes and not Unicode strings. ~ ~ This updates the Beanstalk test suite to use the new helpers for hosting
~ service unit tests, which provide better, more consistent checks with ~ simpler code. The results of all HTTP requests are checked, ensuring ~ we're calling what we expect and that behavior doesn't change in the ~ future. - It turned out we were sending files back as Unicode strings, so this has
- been fixed as well. - - Docstrings for tests and utility functions have been added/updated to
- better fit modern docstring formats. - Commit:
-
fa1394fef737463c67089f15facf82caf3d9e4b9f6dc6e466679710006a26cebd93d3992417e1876
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
