Return the correct user from the last update resource
Review Request #9709 — Created April 25, 2018 and submitted — Latest diff uploaded
A while back we started recording who published review requests in the
ChangeDescription
so that re-assigned review requests showed proper
history (instead of just showing the new author doing everything).
This patch updates theReviewRequestLastUpdateResource
to take this
information into account.As a part of this change,
ReviewRequest.get_last_activity
has been
deprecated in favour of a new method,
ReviewRequest.get_last_activity_info
, which returns a dict of
information, including the relevantChangeDescription
, which can be
used to determine the author of the update.Additionally, unit tests have been added to cover the last update
resource's behaviour.
Ran unit tests.
Diff Revision 4
This is not the most recent revision of the diff. The latest diff is revision 5. See what's changed.
reviewboard/reviews/models/review_request.py |
---|
reviewboard/reviews/tests/test_review_request.py |
---|
reviewboard/webapi/resources/review_request_last_update.py |
---|
reviewboard/webapi/tests/mimetypes.py |
---|
reviewboard/webapi/tests/test_review_request_last_update.py |
---|
reviewboard/webapi/tests/urls.py |
---|