Summary

Return the correct user from the last update resource

Review Request #9709 — Created April 25, 2018 and submitted July 5, 2018, 3:56 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-3.0.x

Bugs

4654

Depends On

~~8800~~

Commit

77756b5...

Reviewers

Groups

reviewboard

People

Description

A while back we started recording who published review requests in the
ChangeDescription so that re-assigned review requests showed proper
history (instead of just showing the new author doing everything).
This patch updates the ReviewRequestLastUpdateResource to take this
information into account.

As a part of this change, ReviewRequest.get_last_activity has been
deprecated in favour of a new method,
ReviewRequest.get_last_activity_info, which returns a dict of
information, including the relevant ChangeDescription, which can be
used to determine the author of the update.

Additionally, unit tests have been added to cover the last update
resource's behaviour.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
E303 too many blank lines (2)	reviewbot	April 25, 2018, 3:26 p.m.
F841 local variable 'updated_obj' is assigned to but never used	reviewbot	April 25, 2018, 3:26 p.m.
I feel like we have three test cases here that should probably be three separate test methods.	david	April 26, 2018, 3:20 p.m.
This blank line should go away too.	david	April 26, 2018, 3:03 p.m.
This blank line should go away too	david	April 26, 2018, 3:03 p.m.
Leftover debug output?	david	April 26, 2018, 3:03 p.m.
We have a new section for docstrings. It goes before Args: Deprecated: 4.0: See blah blah...	chipx86	May 2, 2018, 3:08 p.m.
Missing "Args".	chipx86	May 2, 2018, 3:08 p.m.
Missing indentation. No need for quotes, just the double backticks. Same below.	chipx86	May 2, 2018, 3:08 p.m.
Remove the blank line.	chipx86	May 2, 2018, 3:09 p.m.
is self, probably?	chipx86	May 2, 2018, 3:20 p.m.
Swap these.	chipx86	May 2, 2018, 3:10 p.m.
No blank line.	chipx86	May 2, 2018, 3:10 p.m.
Blank line between these.	chipx86	May 2, 2018, 3:10 p.m.
Blank line between these.	chipx86	May 2, 2018, 3:11 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/tests/test_review_request_last_update.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E303 too many blank lines (2)
```
reviewboard/webapi/tests/test_review_request_last_update.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F841 local variable 'updated_obj' is assigned to but never used
```

Change Summary:

Fix flake8 issues.

Commit:

ec551762e43e0580b147639f2bac06e88a6a7a4d

2db094959b282aa218b0e50343cede90a16b54d5

Diff:

Revision 2 (+526 -5)

Show changes

	reviewboard/reviews/models/review_request.py
	reviewboard/reviews/tests/test_review_request.py
	reviewboard/webapi/resources/review_request_last_update.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/mixins.py
	reviewboard/webapi/tests/test_review_request_last_update.py
	reviewboard/webapi/tests/urls.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/reviews/tests/test_review_request.py (Diff revision 2)

The issue has been resolved. Show all issues

I feel like we have three test cases here that should probably be three separate test methods.

reviewboard/webapi/resources/review_request_last_update.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This blank line should go away too.
```
reviewboard/webapi/resources/review_request_last_update.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This blank line should go away too
```

reviewboard/webapi/tests/mixins.py (Diff revision 2)

The issue has been resolved. Show all issues

Leftover debug output?

Change Summary:

Address David's feedback.

Commit:

2db094959b282aa218b0e50343cede90a16b54d5

e4708c16572c32d700db33fad4fa12782f999645

Diff:

Revision 3 (+590 -17)

Show changes

	reviewboard/reviews/models/review_request.py
	reviewboard/reviews/tests/test_review_request.py
	reviewboard/webapi/resources/review_request_last_update.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_review_request_last_update.py
	reviewboard/webapi/tests/urls.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/reviews/models/review_request.py (Diff revision 3)

The issue has been resolved. Show all issues

We have a new section for docstrings. It goes before Args:

Deprecated:
    4.0:
    See blah blah...

reviewboard/reviews/models/review_request.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Missing "Args".
```
reviewboard/reviews/models/review_request.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Missing indentation.
No need for quotes, just the double backticks. Same below.
```
reviewboard/reviews/models/review_request.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Remove the blank line.
```
reviewboard/reviews/models/review_request.py (Diff revision 3)
The issue has been resolved. Show all issues
```
is self, probably?
```
reviewboard/webapi/tests/test_review_request_last_update.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Swap these.
```
reviewboard/webapi/tests/test_review_request_last_update.py (Diff revision 3)
The issue has been resolved. Show all issues
```
No blank line.
```
reviewboard/webapi/tests/test_review_request_last_update.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Blank line between these.
```
reviewboard/webapi/tests/test_review_request_last_update.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Blank line between these.
```

Change Summary:

Addressed Christian's feedback.

Commit:

e4708c16572c32d700db33fad4fa12782f999645

e70cd048726c693d7c8a0db1ee0c253742eddef9

Diff:

Revision 4 (+590 -17)

Show changes

	reviewboard/reviews/models/review_request.py
	reviewboard/reviews/tests/test_review_request.py
	reviewboard/webapi/resources/review_request_last_update.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_review_request_last_update.py
	reviewboard/webapi/tests/urls.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Commit changes before posting

Commit:

e70cd048726c693d7c8a0db1ee0c253742eddef9

77756b590c0b7a3ac54a82b1d23deeb8ea74530e

Diff:

Revision 5 (+602 -17)

Show changes

	reviewboard/reviews/models/review_request.py
	reviewboard/reviews/tests/test_review_request.py
	reviewboard/webapi/resources/review_request_last_update.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_review_request_last_update.py
	reviewboard/webapi/tests/urls.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (3d1a32c)