Summary

Handle review request summary info without timestamps.

Review Request #9701 — Created Feb. 25, 2018 and submitted Feb. 26, 2018, 4:39 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

07c6ae4...

Reviewers

Groups

reviewboard

People

Description

Old review requests from years back didn't track the closing times of
review requests. This broke the new review request status information
code, which assumed a valid timestamp to parse and display. The old
mechanism ignored this due to templates in Django 1.6 silently ignoring
failures.

Now, if the timestamp for a close is None, we just won't attempt to
show timestamp information.

Testing Done

Unit tests pass.

Tested with review requests that were closed but lacking close info.

Issues

Description	From	Last Updated
Just to be consistent in our naming, can we change this to closed_time?	david	Feb. 25, 2018, 10:42 p.m.
Same here.	david	Feb. 25, 2018, 10:40 p.m.

flake8 passed.

JSHint passed.

reviewboard/reviews/views.py (Diff revision 1)

The issue has been dropped. Show all issues

Just to be consistent in our naming, can we change this to closed_time?

chipx86 Feb. 25, 2018, 10:41 p.m.

The timestamp isn't just used for close statuses or for this new text conditional. It's used for other statuses as well.

reviewboard/reviews/views.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Same here.
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (d7e11ce)