Summary

Fix help text for Media URL and Static URL.

Review Request #9696 — Created Feb. 23, 2018 and submitted March 7, 2018, 10:31 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

5395a65...

Reviewers

Groups

reviewboard

People

Description

The help text in the admin UI for the Media URL and Static URL fields
suggested that you could leave them blank to use the defaults. This
was a lie. This change fixes that up, and makes the fields required,
since they are.

Testing Done

Loaded the general settings page and saw the correct help text.

Issues

Description	From	Last Updated
This will only be true if on a non-subdirectory install. We should have this factor in settings.SITE_ROOT.	chipx86	Feb. 24, 2018, 9:42 a.m.

flake8 passed.

JSHint passed.

reviewboard/admin/forms.py (Diff revision 1)

The issue has been resolved. Show all issues

This will only be true if on a non-subdirectory install. We should have this factor in settings.SITE_ROOT.

Commit:

8f38f91a1a0ad6be522e2e7b4652a2beaa4c49fd

5395a65d686a08da8a3e9c76a8433d5c32ac6491

Diff:

Revision 2 (+12 -8)

Show changes

reviewboard/admin/forms.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (4537d6a)