Update us to the latest Backbone.js
Review Request #9694 — Created Feb. 23, 2018 and submitted — Latest diff uploaded
This change moves us over to Backbone 1.3.3. There are three changes
to the API that required updates:
this.options
is no longer set when initializing views, and has to be
done manually if desired. We only had about 10 views that actually
usedthis.options
, so this isn't too invasive. I've updated
documentation where our docs were already in the new style, and
otherwise left it the same for old code (which will be updated for our
new doc standards in due time).- Callbacks from
Model.destroy()
are now asynchronous. This doesn't
actually affect the UI at all, but did affect some unit tests which were
written with the assumption that it was synchronous. Events.listenTo
no longer callsEvents.on
, instead delegating to
an internal function. I've updated the test that checked this to instead
check the internal listener state (which is probably about as fragile).
- Ran js-tests.
- Smoke tested the UI.