Summary

Update us to the latest Backbone.js

Review Request #9694 — Created Feb. 23, 2018 and submitted March 7, 2018, 7:08 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

a665c88...

Reviewers

Groups

reviewboard

People

Description

This change moves us over to Backbone 1.3.3. There are three changes
to the API that required updates:

this.options is no longer set when initializing views, and has to be
done manually if desired. We only had about 10 views that actually
used this.options, so this isn't too invasive. I've updated
documentation where our docs were already in the new style, and
otherwise left it the same for old code (which will be updated for our
new doc standards in due time).
Callbacks from Model.destroy() are now asynchronous. This doesn't
actually affect the UI at all, but did affect some unit tests which were
written with the assumption that it was synchronous.
Events.listenTo no longer calls Events.on, instead delegating to
an internal function. I've updated the test that checked this to instead
check the internal listener state (which is probably about as fragile).

Testing Done


Ran js-tests.
Smoke tested the UI.

Issues

Description	From	Last Updated
Col: 29 Expected '===' and instead saw '=='.	reviewbot	Feb. 23, 2018, 9:19 p.m.
Col: 30 Expected '===' and instead saw '=='.	reviewbot	Feb. 23, 2018, 9:19 p.m.
Col: 22 Expected '{' and instead saw 'Class'.	reviewbot	Feb. 23, 2018, 9:19 p.m.
Col: 7 'cb' was used before it was defined.	reviewbot	Feb. 23, 2018, 9:19 p.m.
Col: 33 Expected '{' and instead saw 'return'.	reviewbot	Feb. 23, 2018, 9:19 p.m.
Col: 63 Expected '{' and instead saw 'return'.	reviewbot	Feb. 23, 2018, 9:19 p.m.
Col: 31 Expected '{' and instead saw 'return'.	reviewbot	Feb. 23, 2018, 9:19 p.m.
Col: 7 'modelMatcher' was used before it was defined.	reviewbot	Feb. 23, 2018, 9:19 p.m.
Col: 80 Expected '{' and instead saw 'opts'.	reviewbot	Feb. 23, 2018, 9:19 p.m.
Col: 7 'internalOn' was used before it was defined.	reviewbot	Feb. 23, 2018, 9:19 p.m.
Col: 15 Expected '{' and instead saw 'return'.	reviewbot	Feb. 23, 2018, 9:19 p.m.
Col: 7 'onApi' was used before it was defined.	reviewbot	Feb. 23, 2018, 9:19 p.m.
Col: 22 Expected '{' and instead saw 'listening'.	reviewbot	Feb. 23, 2018, 9:19 p.m.
Col: 24 Expected '{' and instead saw 'return'.	reviewbot	Feb. 23, 2018, 9:19 p.m.
Col: 23 Expected '{' and instead saw 'return'.	reviewbot	Feb. 23, 2018, 9:19 p.m.
Col: 23 Expected '{' and instead saw 'break'.	reviewbot	Feb. 23, 2018, 9:19 p.m.
Col: 7 'offApi' was used before it was defined.	reviewbot	Feb. 23, 2018, 9:19 p.m.
Col: 18 Expected '{' and instead saw 'return'.	reviewbot	Feb. 23, 2018, 9:19 p.m.
Col: 22 Expected '{' and instead saw 'break'.	reviewbot	Feb. 23, 2018, 9:19 p.m.
Col: 47 Expected '===' and instead saw '=='.	reviewbot	Feb. 23, 2018, 9:19 p.m.
Col: 54 Expected '{' and instead saw 'callback'.	reviewbot	Feb. 23, 2018, 9:19 p.m.
Col: 7 'onceMap' was used before it was defined.	reviewbot	Feb. 23, 2018, 9:20 p.m.
Col: 38 Expected '{' and instead saw 'args'.	reviewbot	Feb. 23, 2018, 9:20 p.m.
Col: 7 'triggerApi' was used before it was defined.	reviewbot	Feb. 23, 2018, 9:20 p.m.
Col: 32 Expected '{' and instead saw 'allEvents'.	reviewbot	Feb. 23, 2018, 9:20 p.m.
Col: 19 Expected '{' and instead saw 'triggerEvents'.	reviewbot	Feb. 23, 2018, 9:20 p.m.
Col: 22 Expected '{' and instead saw 'triggerEvents'.	reviewbot	Feb. 23, 2018, 9:20 p.m.
Col: 32 Expected '{' and instead saw '('.	reviewbot	Feb. 23, 2018, 9:20 p.m.
Col: 29 Expected '{' and instead saw 'this'.	reviewbot	Feb. 23, 2018, 9:20 p.m.
Col: 38 Expected '{' and instead saw 'this'.	reviewbot	Feb. 23, 2018, 9:20 p.m.
Col: 29 Expected '===' and instead saw '=='.	reviewbot	Feb. 24, 2018, 5:32 p.m.
Col: 30 Expected '===' and instead saw '=='.	reviewbot	Feb. 24, 2018, 5:32 p.m.
Col: 22 Expected '{' and instead saw 'Class'.	reviewbot	Feb. 24, 2018, 5:32 p.m.
Col: 7 'cb' was used before it was defined.	reviewbot	Feb. 24, 2018, 5:32 p.m.
Col: 33 Expected '{' and instead saw 'return'.	reviewbot	Feb. 24, 2018, 5:32 p.m.
Col: 63 Expected '{' and instead saw 'return'.	reviewbot	Feb. 24, 2018, 5:32 p.m.
Col: 31 Expected '{' and instead saw 'return'.	reviewbot	Feb. 24, 2018, 5:32 p.m.
Col: 7 'modelMatcher' was used before it was defined.	reviewbot	Feb. 24, 2018, 5:32 p.m.
Col: 80 Expected '{' and instead saw 'opts'.	reviewbot	Feb. 24, 2018, 5:32 p.m.
Col: 7 'internalOn' was used before it was defined.	reviewbot	Feb. 24, 2018, 5:32 p.m.
Col: 15 Expected '{' and instead saw 'return'.	reviewbot	Feb. 24, 2018, 5:32 p.m.
Col: 7 'onApi' was used before it was defined.	reviewbot	Feb. 24, 2018, 5:32 p.m.
Col: 22 Expected '{' and instead saw 'listening'.	reviewbot	Feb. 24, 2018, 5:32 p.m.
Col: 24 Expected '{' and instead saw 'return'.	reviewbot	Feb. 24, 2018, 5:32 p.m.
Col: 23 Expected '{' and instead saw 'return'.	reviewbot	Feb. 24, 2018, 5:32 p.m.
Col: 23 Expected '{' and instead saw 'break'.	reviewbot	Feb. 24, 2018, 5:32 p.m.
Col: 7 'offApi' was used before it was defined.	reviewbot	Feb. 24, 2018, 5:32 p.m.
Col: 18 Expected '{' and instead saw 'return'.	reviewbot	Feb. 24, 2018, 5:32 p.m.
Col: 22 Expected '{' and instead saw 'break'.	reviewbot	Feb. 24, 2018, 5:32 p.m.
Col: 47 Expected '===' and instead saw '=='.	reviewbot	Feb. 24, 2018, 5:32 p.m.
Col: 54 Expected '{' and instead saw 'callback'.	reviewbot	Feb. 24, 2018, 5:32 p.m.
Col: 7 'onceMap' was used before it was defined.	reviewbot	Feb. 24, 2018, 5:32 p.m.
Col: 38 Expected '{' and instead saw 'args'.	reviewbot	Feb. 24, 2018, 5:32 p.m.
Col: 7 'triggerApi' was used before it was defined.	reviewbot	Feb. 24, 2018, 5:32 p.m.
Col: 32 Expected '{' and instead saw 'allEvents'.	reviewbot	Feb. 24, 2018, 5:33 p.m.
Col: 19 Expected '{' and instead saw 'triggerEvents'.	reviewbot	Feb. 24, 2018, 5:33 p.m.
Col: 22 Expected '{' and instead saw 'triggerEvents'.	reviewbot	Feb. 24, 2018, 5:33 p.m.
Col: 32 Expected '{' and instead saw '('.	reviewbot	Feb. 24, 2018, 5:33 p.m.
Col: 29 Expected '{' and instead saw 'this'.	reviewbot	Feb. 24, 2018, 5:33 p.m.
Col: 38 Expected '{' and instead saw 'this'.	reviewbot	Feb. 24, 2018, 5:33 p.m.

flake8 passed.

JSHint failed.

JSHint

```
Warning: Showing 30 of 82 failures.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 29
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 30
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 22
 Expected '{' and instead saw 'Class'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 7
 'cb' was used before it was defined.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 33
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 63
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 31
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 7
 'modelMatcher' was used before it was defined.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 Expected '{' and instead saw 'opts'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 7
 'internalOn' was used before it was defined.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 15
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 7
 'onApi' was used before it was defined.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 22
 Expected '{' and instead saw 'listening'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 24
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 23
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 23
 Expected '{' and instead saw 'break'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 7
 'offApi' was used before it was defined.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 18
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 22
 Expected '{' and instead saw 'break'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 47
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 54
 Expected '{' and instead saw 'callback'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 7
 'onceMap' was used before it was defined.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 38
 Expected '{' and instead saw 'args'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 7
 'triggerApi' was used before it was defined.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 32
 Expected '{' and instead saw 'allEvents'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 19
 Expected '{' and instead saw 'triggerEvents'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 22
 Expected '{' and instead saw 'triggerEvents'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 32
 Expected '{' and instead saw '('.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 29
 Expected '{' and instead saw 'this'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 38
 Expected '{' and instead saw 'this'.
```

Thanks for doing this :) So glad we're finally getting out of the dark ages on Backbone.

reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewReplyEditorModelTests.js (Diff revision 1)

We can't just spy on listenTo itself?

Branch:

release-4.0.x

master

Commit:

7451ab4bd72a11976731e0bc3fadb268aa84b037

a665c889b4c776d7f9691d1b0db533b671b9b779

Diff:

Revision 2 (+1070 -565)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/lib/js/backbone-1.0.0.min.js
	reviewboard/static/lib/js/backbone-1.0.0.min.map
	reviewboard/static/lib/js/backbone-1.0.0.js
	reviewboard/static/lib/js/backbone-1.3.3.min.js
	reviewboard/static/lib/js/backbone-1.3.3.min.map
	reviewboard/static/rb/js/diffviewer/views/diffFileIndexView.js
	reviewboard/static/rb/js/diffviewer/views/diffRevisionSelectorView.js
	18 more

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

```
Warning: Showing 30 of 84 failures.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 29
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 30
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 22
 Expected '{' and instead saw 'Class'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 7
 'cb' was used before it was defined.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 33
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 63
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 31
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 7
 'modelMatcher' was used before it was defined.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 Expected '{' and instead saw 'opts'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 7
 'internalOn' was used before it was defined.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 15
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 7
 'onApi' was used before it was defined.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 22
 Expected '{' and instead saw 'listening'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 24
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 23
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 23
 Expected '{' and instead saw 'break'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 7
 'offApi' was used before it was defined.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 18
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 22
 Expected '{' and instead saw 'break'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 47
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 54
 Expected '{' and instead saw 'callback'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 7
 'onceMap' was used before it was defined.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 38
 Expected '{' and instead saw 'args'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 7
 'triggerApi' was used before it was defined.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 32
 Expected '{' and instead saw 'allEvents'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 19
 Expected '{' and instead saw 'triggerEvents'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 22
 Expected '{' and instead saw 'triggerEvents'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 32
 Expected '{' and instead saw '('.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 29
 Expected '{' and instead saw 'this'.
```
reviewboard/static/lib/js/backbone-1.3.3.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 38
 Expected '{' and instead saw 'this'.
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (5327c29)