Summary

Check length for parents before usage

Review Request #9679 — Created Feb. 20, 2018 and submitted March 2, 2018, 2:12 p.m.

Information

Owner

misery

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

bb290e0...

Reviewers

Groups

reviewboard

People

Description

The first changeset cannot have a parent so this would be an empty list.
That should be checked.

Sometimes mercurial uses "0000000000000000000000000000000000000000"
to indicate that the parent is the "null" changeset. Sometimes the
array is empty.

Testing Done

Used a repo with a few changesets. Saw
that it will result into an error if first
changeset will be fetched with cmdline or hgweb.

Added this change and saw that cmdline and hgweb
won't get an error.

Issues

Description	From	Last Updated
We generally avoid the python ternary syntax because it's ugly. I know it's a bit longer but this is preferable: …	david	March 2, 2018, 1:56 p.m.
Same here. Can you also fix up the naming of p to be parent to not shadow the process handle?	david	March 2, 2018, 1:56 p.m.

flake8 passed.

JSHint passed.

Testing Done:: Used a repo with a few changesets. Saw
that it will result into an error if first
~ changeset will be fetch with cmdline or hgweb.
~ changeset will be fetched with cmdline or hgweb.

Added this change and saw that cmdline and hgweb
won't get an error.

reviewboard/scmtools/hg.py (Diff revision 1)

The issue has been resolved. Show all issues

We generally avoid the python ternary syntax because it's ugly. I know it's a bit longer but this is preferable:

try:
    parent = data['parents'][0]
except IndexError:
    parent = None

reviewboard/scmtools/hg.py (Diff revision 1)

The issue has been resolved. Show all issues

Same here. Can you also fix up the naming of p to be parent to not shadow the process handle?

Description:

~		The first changeset cannot have a parent so
~		this would be an empty list. That should be
~		checked.
	~	The first changeset cannot have a parent so this would be an empty list.
	~	That should be checked.
	~
	+	Sometimes mercurial uses "0000000000000000000000000000000000000000"
	+	to indicate that the parent is the "null" changeset. Sometimes the
	+	array is empty.

Commit:

2363eaf25f49de25250cc8e21bf64f2611275c32

bb290e0b0ce1e09e453c00ba186b771e8010a6e2

Diff:

Revision 2 (+17 -5)

Show changes

reviewboard/scmtools/hg.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (c1e6e62)

		Used a repo with a few changesets. Saw
		that it will result into an error if first
~		changeset will be fetch with cmdline or hgweb.
	~	changeset will be fetched with cmdline or hgweb.

		Added this change and saw that cmdline and hgweb
		won't get an error.