Summary

Start adding Redux for data management.

Review Request #9678 — Created Feb. 19, 2018 and submitted March 3, 2018, 1:44 p.m.

Information

Owner

david

Repository

student-sonar

Branch

master

Bugs

Depends On

Commit

0c0a46a...

Reviewers

Groups

student-sonar

People

Description

Backbone models and collections are not a great way to store data for a
react application. This change starts the (probably lengthy) process of
migrating towards a Redux data management model. The first thing which
is really migrated here is the project ideas, which is one of the most
isolated pieces of data.

In order to match things up here, this also includes the start of
migration for the users and the "manage" state. Those are only very
partially migrated, so there's a lot more work to do there.

Testing Done

Navigated around through the three views that use projects (the project
list, the single project view, and the user detail view) and saw that
everything worked as expected.

Issues

Description	From	Last Updated
Now that we're using redux, you may want to include userType etc in the state and hydrate from the JS …	brennie	Feb. 20, 2018, 2:20 p.m.
Col: 2 Unnecessary semicolon.	reviewbot	Feb. 19, 2018, 3:55 p.m.
Col: 52 Regular parameters should not come after default parameters.	reviewbot	Feb. 19, 2018, 3:55 p.m.
Col: 59 Regular parameters should not come after default parameters.	reviewbot	Feb. 19, 2018, 3:55 p.m.
Col: 59 Regular parameters should not come after default parameters.	reviewbot	Feb. 19, 2018, 3:55 p.m.
Col: 52 Regular parameters should not come after default parameters.	reviewbot	Feb. 20, 2018, 3:03 p.m.
Col: 59 Regular parameters should not come after default parameters.	reviewbot	Feb. 20, 2018, 3:03 p.m.
Col: 59 Regular parameters should not come after default parameters.	reviewbot	Feb. 20, 2018, 3:03 p.m.

flake8 passed.

JSHint failed.

JSHint

lib/frontend/redux/configure-store.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 2
 Unnecessary semicolon.
```
lib/frontend/redux/modules/manage.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 52
 Regular parameters should not come after default parameters.
```
lib/frontend/redux/modules/projects.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 59
 Regular parameters should not come after default parameters.
```
lib/frontend/redux/modules/users.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 59
 Regular parameters should not come after default parameters.
```

lib/frontend/project.jsx (Diff revision 1)

The issue has been dropped. Show all issues

Now that we're using redux, you may want to include userType etc in the state and hydrate from the JS that gets splatted into the page.

david Feb. 20, 2018, 2:20 p.m.
```
Yeah, that's in the pipeline.
```

```
Ship It!
```

Commit:

04e38af052e4f49192a8e3612fe49092d6f5707f

0c0a46a81c3e3e75c77d26c3af878376b92d43ab

Diff:

Revision 2 (+447 -232)

Show changes

	package.json
	package-lock.json
	css/style.less
	lib/asana.js
	lib/frontend/application.jsx
	lib/frontend/application-model.js
	lib/frontend/header.jsx
	lib/frontend/main.js
	9 more

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

lib/frontend/redux/modules/manage.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 52
 Regular parameters should not come after default parameters.
```
lib/frontend/redux/modules/projects.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 59
 Regular parameters should not come after default parameters.
```
lib/frontend/redux/modules/users.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 59
 Regular parameters should not come after default parameters.
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (e057d1d)