Summary

Get rid of ApplicationView.

Review Request #9677 — Created Feb. 19, 2018 and submitted March 3, 2018, 1:44 p.m.

Information

Owner

david

Repository

student-sonar

Branch

master

Bugs

Depends On

Commit

21f9f9c...

Reviewers

Groups

student-sonar

People

Description

This moves the final backbone view over to React, the application
wrapper. Along with this I've deleted a handful of utility classes
(CollectionView, FilteredCollection, GroupByCollection) that are no
longer used.

Testing Done

Loaded sonar and clicked around the app. Saw that everything worked as
expected.

Issues

Description	From	Last Updated
Col: 9 Expected an identifier and instead saw '<'.	reviewbot	Feb. 19, 2018, 12:30 p.m.
Col: 10 Expected ')' and instead saw 'Application'.	reviewbot	Feb. 19, 2018, 12:30 p.m.
Col: 21 Missing semicolon.	reviewbot	Feb. 19, 2018, 12:30 p.m.
Col: 42 Unclosed regular expression.	reviewbot	Feb. 19, 2018, 12:30 p.m.
Col: 42 Unrecoverable syntax error. (78% scanned).	reviewbot	Feb. 19, 2018, 12:30 p.m.

flake8 passed.

JSHint failed.

JSHint

lib/frontend/main.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 9
 Expected an identifier and instead saw '<'.
```
lib/frontend/main.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 10
 Expected ')' and instead saw 'Application'.
```
lib/frontend/main.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 21
 Missing semicolon.
```
lib/frontend/main.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 42
 Unclosed regular expression.
```
lib/frontend/main.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 42
 Unrecoverable syntax error. (78% scanned).
```

Commit:

2907309480e0478f408bd52a22fecd28fcddcec1

45e6d18a7406b3986a0accce84aa49294ddd6543

Diff:

Revision 2 (+31 -270)

Show changes

	lib/routes.js
	lib/frontend/all-status-reports.jsx
	lib/frontend/all-users.jsx
	lib/frontend/application-view.js
	lib/frontend/application.js
	lib/frontend/collection-view.js
	lib/frontend/filtered-collection.js
	lib/frontend/group-by-collection.js
	5 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commit:

45e6d18a7406b3986a0accce84aa49294ddd6543

21f9f9cd55e3cfbe082604db2d87a3ab16fce9a3

Diff:

Revision 3 (+26 -265)

Show changes

	lib/routes.js
	lib/frontend/application-view.js
	lib/frontend/application.js
	lib/frontend/collection-view.js
	lib/frontend/filtered-collection.js
	lib/frontend/group-by-collection.js
	lib/frontend/main.js
	lib/frontend/ready-view.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status:: Completed
Change Summary:: Pushed to master (658a5bf)

lib/frontend/main.js (Diff revision 1)

lib/frontend/main.js (Diff revision 1)

lib/frontend/main.js (Diff revision 1)

lib/frontend/main.js (Diff revision 1)