Fix various PEP 8, style and PyFlakes issues

Review Request #9655 — Created Feb. 16, 2018 and submitted — Latest diff uploaded

solarmist
RBTools
master
9654
9648
6540441...
rbtools

Fix various PEP 8, sytle and PyFlakes issues.

I've also included an exception for E129 in the setup.cfg to make it explicit in the codebase
that this is the expected style.

(%) flake8 -v tests rbtools

flake8.checker MainProcess 409 INFO Making checkers
flake8.checker MainProcess 650 INFO Checking 79 files
flake8.main.application MainProcess 2483 INFO Finished running
flake8.main.application MainProcess 2484 INFO Reporting errors
flake8.main.application MainProcess 2485 INFO Found a total of 37 violations and reported 0

Note: These violations were in appdirs.py and the docs directory.

time ./tests/runtests.py
/Volumes/Augie/solarmist/rbtools/lib/python2.7/site-packages/nose/pyversion.py:36: DeprecationWarning: The 'new' module has been removed in Python 3.0; use the 'types' module instead.
import new
/Volumes/Augie/solarmist/rbtools/lib/python2.7/site-packages/nose/plugins/prof.py:14: DeprecationWarning: The 'hotshot' module is not supported in 3.x, use the 'profile' module instead.
import hotshot
/Volumes/Augie/solarmist/rbtools/lib/python2.7/site-packages/nose/pyversion.py:49: DeprecationWarning: Overriding __eq__ blocks inheritance of __hash__ in 3.x
class Key(object):
#1 Testing the cache with a high max-age value ... /Volumes/Augie/solarmist/rbtools/rbtools/api/cache.py:479: DeprecationWarning: buffer() not supported in 3.x
sqlite3.Binary(entry.response_body)))
ok
#2 Testing the cache with a zero max-age value ... /Volumes/Augie/solarmist/rbtools/rbtools/api/cache.py:493: DeprecationWarning: buffer() not supported in 3.x
sqlite3.Binary(entry.response_body), entry.url,
ok

Ran 210 tests in 215.007s

OK
./tests/runtests.py 93.50s user 60.71s system 71% cpu 3:35.47 total

Loading...