• 
      

    Cleanup the UploadDiffForms

    Review Request #9638 — Created Feb. 14, 2018 and submitted

    Information

    Review Board
    release-4.0.x
    5a32d89...

    Reviewers

    The diffviewer.forms.UploadDiffForm and reviews.forms.UploadDiffForm
    were really out of date with current (Django 1.6) Django forms and our
    documentation standards. The create() method on both was taking in
    arguments that were already known by the form and did not verify that
    the form was valid before attempting to create the models.

    These issues have all been addressed and unit tests updated.

    Ran unit tests.

    Description From Last Updated

    E501 line too long (82 > 79 characters)

    reviewbot reviewbot
    Checks run (1 failed, 1 succeeded)
    flake8 failed.
    JSHint passed.

    flake8

    brennie
    brennie
    david
    1. Ship It!
    2. 
        
    brennie
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-4.0.x (d6bab51)