Summary

Clean up the form-related template tags/filters and add unit tests.

Review Request #9619 — Created Feb. 10, 2018 and submitted Feb. 17, 2018, 1:01 a.m.

Information

Owner

chipx86

Repository

Djblets

Branch

master

Bugs

Depends On

Commit

72ea639...

Reviewers

Groups

djblets

People

Description

The form-related template tags and filters in
djblets.util.templatetags.djblets_forms are pretty old, and have some
outdated logic and almost no test coverage or documentation. This change
modernizes them, fixing them up to meet current standards and to have
comprehensive test coverage.

Testing Done

Unit tests pass.

Issues

Description	From	Last Updated
E303 too many blank lines (2)	reviewbot	Feb. 10, 2018, 5:42 p.m.
F811 redefinition of unused 'test_with_checkbox_input' from line 235	reviewbot	Feb. 10, 2018, 5:43 p.m.

flake8 failed.

JSHint passed.

flake8

djblets/util/tests/test_djblets_forms_tags.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E303 too many blank lines (2)
```
djblets/util/tests/test_djblets_forms_tags.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F811 redefinition of unused 'test_with_checkbox_input' from line 235
```

Change Summary:

Fixed Review Bot complaints.

Commit:

860e1791c12826b93a1ef50f72db05f6251019f0

72ea639547b37f241d167701ca55c7d545645d77

Diff:

Revision 2 (+348 -33)

Show changes

	djblets/util/templatetags/djblets_forms.py
	djblets/util/tests/test_djblets_forms_tags.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.0.x (9505fde)