flake8
passed.
JSHint
passed.
Fix integration config forms to show local site when fieldsets exist.
Review Request #9604 — Created Feb. 9, 2018 and submitted
All integration configs for Review Board automatically include a local
site field. In the case where there were no fieldsets, all the fields
would show up fine, but if the form tried to group things, the local
site field would disappear. This is because the djblets form was
defining the basic info fieldset with only the "name" and "enable"
fields.I've fixed the Review Board form to properly override the basic info
fieldset, so that local site shows up everywhere.
Loaded some integration config forms that previously exhibited a missing
"Local Site" field. Saw the field appear.
- Description:
-
~ All integration configs for review board automatically include a local
~ All integration configs for Review Board automatically include a local
site field. In the case where there were no fieldsets, all the fields would show up fine, but if the form tried to group things, the local site field would disappear. This is because the djblets form was defining the basic info fieldset with only the "name" and "enable" fields. I've fixed the Review Board form to properly override the basic info
fieldset, so that local site shows up everywhere. - - Testing done:
- Loaded some integration config forms that previously exhibited a missing - "Local Site" field. Saw the field appear. - Testing Done:
-
+ Loaded some integration config forms that previously exhibited a missing
+ "Local Site" field. Saw the field appear.
