flake8
passed.
JSHint
passed.
Add support to scan specific files only
Review Request #9530 — Created Jan. 25, 2018 and submitted
PMD supports multiple languages. But most checks
are for java files only as the other languages
are for CPD only or requires manually added checks.This features allows to increase the performance
of review checks as it is not necessary to run PMD
for all files in a diff if only .java has enabled
checks. Also this avoid but not fix bug #4633.Also increase timeout as big patches with a lot
of files will take some time to be finished.Fixes conflicting variable name 'f' introduced by
changeset f95629e2739037bd0e0f289875f710f2da4aa2dd
by mistake.
Added some binary files with another file extension
and saw that it wasn't scanned.Enabled java extension only and added a java file.
Saw that the check found correct issues.Leave the extension setting empty and saw that it
still found correct issues in uploaded java patch.Used "cpp" as file extension and saw that it
ignores java files.
-
-
Can you flesh out the description a bit? The summary "Add support to scan specific files only" doesn't adequately describe what the change does or the motivation for it.
See https://www.notion.so/reviewboard/Writing-Good-Change-Descriptions-10529e7c207743fa8ca90153d4b21fea for our guidelines on this.
-
We generally prefer putting the joining space at the end of the line instead of the beginning of the next.
- Description:
-
~ - Fixes variable naming mistake 'f'.
~ - Increase timeout as big patches will
take some time.
~ PMD supports multiple languages. But most checks
~ are for java files only as the other languages + are for CPD only or requires manually added checks. + + This features allows to increase the performance
+ of review checks as it is not necessary to run PMD + for all files in a diff if only .java has enabled + checks. Also this avoid but not fix bug #4633. + + Also increase timeout as big patches with a lot
+ of files will take some time to be finished. + + Fixes conflicting variable name 'f' introduced by
+ changeset f95629e2739037bd0e0f289875f710f2da4aa2dd + by mistake. - Commit:
-
ec7edbd43f0401c15d1ed5fb723a686c3d88c899a0b5c9d5ea56100d144eb058160cbe8c851f203e
- Diff:
-
Revision 2 (+21 -4)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Testing Done:
-
Added some binary files with another file extension
and saw that it wasn't scanned. ~ Added a java file and scan correct issues in reviewboard.
~ Enabled java extension only and added a java file.
+ Saw that the check found correct issues. + + Leave the extension setting empty and saw that it
+ still found correct issues in uploaded java patch. + + Used "cpp" as file extension and saw that it
+ ignores java files. - Commit:
-
a0b5c9d5ea56100d144eb058160cbe8c851f203e5befb928a2b8656b4cef165280ff8e814c339ef7
- Diff:
-
Revision 3 (+23 -4)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.