flake8
passed.
JSHint
passed.
Fix compatibility with newer kgb changes.
Review Request #9513 — Created Jan. 20, 2018 and submitted
kgb is getting a handful of changes to improve signature consistency and
compatibility across Python versions. As part of this, Review Board's
test suite needs a few changes.Some fake functions passed when creating spies had incompatible function
signatures, which kgb is now strict about. Those have been updated
accordingly.Some older tests were checking the args and kwargs of a spy call
directly, which failed due to how kgb is now storing this data. Those
have been replaced withcalled_with()statements instead.
Unit tests pass with the new kgb.
- Change Summary:
-
This now includes more fixes for changes being made in kgb.
- Summary:
-
Fix two function signatures for method spies.Fix compatibility with newer kgb changes.
- Description:
-
~ There are two fake spy methods in the unit tests that use the wrong
~ function signatures. One doesn't take the keyword arguments expected by ~ the function, and the other takes one in a positional argument's slot. ~ This change fixes both of these signatures to be compatible with the ~ original functions. ~ kgb is getting a handful of changes to improve signature consistency and
~ compatibility across Python versions. As part of this, Review Board's ~ test suite needs a few changes. ~ ~ Some fake functions passed when creating spies had incompatible function
+ signatures, which kgb is now strict about. Those have been updated + accordingly. + + Some older tests were checking the args and kwargs of a spy call
+ directly, which failed due to how kgb is now storing this data. Those + have been replaced with called_with()statements instead. - Commit:
-
7aa801c991663f3ed0c27b980d1746e98fd09527707e57e23904ca9258c9efd94b7cec460555ffaa
- Diff:
-
Revision 2 (+49 -69)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
