flake8
passed.
JSHint
passed.
Reordered transaction rollback to be called before an error is raised.
Review Request #9494 — Created Jan. 19, 2018 and submitted
The loaddb management command had a bug where the code to rollback the
transaction occured after a "raise", meaning it would never be reached.
I reordered this so the raise happens after the transaction code.
There aren't a ton of tests in the reviewboard/admin module but the 5 tests in there ran successfully.
| Description | From | Last Updated |
|---|---|---|
|
The bug number should go in the Bugs field, instead of having a URL in the description. |
 chipx86
|
|
|
The description should be capped at around 75 characters. Many editors will enforce a line length for Git commits, which … |
chipx86
|
|
|
Testing doesn't really need to describe the state of the tests in the directory. However, you should introduce unit tests … |
chipx86
|
-
-
-
The description should be capped at around 75 characters. Many editors will enforce a line length for Git commits, which is applicable here.
-
Testing doesn't really need to describe the state of the tests in the directory. However, you should introduce unit tests for anything you fix, or we can't prove it was fixed (or that it won't regress).
JC
- Description:
-
~ The loaddb management command had a bug where the code to rollback the transaction occured after a "raise", meaning it would never be reached. I reordered this so the raise happens after the transaction code.
~ ~ https://hellosplat.com/s/beanbag/tickets/4629/
~ The loaddb management command had a bug where the code to rollback the
~ transaction occured after a "raise", meaning it would never be reached. ~ I reordered this so the raise happens after the transaction code. - Bugs:
