• 
      

    Fix up "Tool Options" bugs in integration config.

    Review Request #9492 — Created Jan. 17, 2018 and submitted

    Information

    ReviewBot
    master
    ae37b9b...

    Reviewers

    Some recent changes to the configforms module added an extra
    <div class="field"> inside each row. This mucked up some of the JS and
    CSS used in Review Bot's integration config, which does some crazy stuff
    with sub-rows in order to configure tool-specific options.

    This change fixes those up to handle things correctly in either case.

    • Loaded the integration config page and saw that there was no longer a
      useless "Tool Options" label.
    • Changed the "Tool" field to a few different things and saw the correct
      tool options rows appear.
    misery
    1. Works great here! Thanks....

    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (7500069)