• 
      

    Prevent gravatars from exploding if users don't have an email address.

    Review Request #9491 — Created Jan. 17, 2018 and submitted

    Information

    Djblets
    release-1.0.x
    4e7ed8c...

    Reviewers

    The recent changes to the gravatar backend were causing uncaught
    ValueErrors to percolate upwards for users with empty email addresses,
    breaking a variety of things. Not having an avatar shouldn't be a fatal
    condition, so I've changed it to return an empty dict instead.

    • Ran unit tests.
    • Tested in conjunction with some other stuff that was previously
      breaking.
    Description From Last Updated

    Can you add a unit test for this?

    chipx86chipx86
    chipx86
    1. 
        
    2. Show all issues

      Can you add a unit test for this?

    3. 
        
    david
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-1.0.x (0a989cd)