Fix compatibility of I Done This integration with released RB 3.0
Review Request #9466 — Created Dec. 31, 2017 and submitted — Latest diff uploaded
My last update to https://reviews.reviewboard.org/r/8776/ was done right
before some changes in the main RB repository caused an incompatibility:
https://reviews.reviewboard.org/r/9323/This change addresses the breakage and a few more issues with unit tests:
to_submitter_only
renamed toto_owner_only
to match RB 3.0 API.- Avoid calling
set(None)
ifget_user_team_ids
fails, and instead copy
the set before returning the cached result fromget_user_team_ids
.
The exception was caught and ignored by the signal hook, so it did not show
up in unit tests unless a failed test printed the logged error.- Check for exceptions in more unit tests to avoid hiding the above issue.
- Add a new test for review request signal and error during team IDs request.
- Fake
urlopen
calls need**kwargs
after a recentkgb
update, otherwise
the fake call raises an exception due to unhandled default arguments.
All unit tests pass.
Manually verified that posting to I Done This works as expected.