
david got a fish trophy!

Fix a bug where "Download Diff" would vanish.
Review Request #9449 — Created Dec. 18, 2017 and submitted — Latest diff uploaded
When loading a diff, the "Download Diff" action would be visible for a
short time, and then vanish. The culprit was that we were setting the
canDownloadDiff
attribute in the code that loads a new revision, but
we had optimized the first load a little bit by including the context in
the initial page payload rather than making a separate request.This change fixes things so that we compute the correct state of this
inside theparse
method, which is used for both the initial load as
well as subsequent revisions.
- Verified that "Download Diff" was no longer vanishing when it
shouldn't. - Ran js-tests.
Diff Revision 1
This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.
orig
1
2
reviewboard/static/rb/js/pages/models/diffViewerPageModel.es6.js |
---|
reviewboard/static/rb/js/pages/models/tests/diffViewerPageModelTests.es6.js |
---|