• 
      
    Fish Trophy

    david got a fish trophy!

    Fish Trophy

    Fix a bug where "Download Diff" would vanish.

    Review Request #9449 — Created Dec. 19, 2017 and submitted

    Information

    Review Board
    release-3.0.x
    5ecae30...

    Reviewers

    When loading a diff, the "Download Diff" action would be visible for a
    short time, and then vanish. The culprit was that we were setting the
    canDownloadDiff attribute in the code that loads a new revision, but
    we had optimized the first load a little bit by including the context in
    the initial page payload rather than making a separate request.

    This change fixes things so that we compute the correct state of this
    inside the parse method, which is used for both the initial load as
    well as subsequent revisions.

    • Verified that "Download Diff" was no longer vanishing when it
      shouldn't.
    • Ran js-tests.
    Description From Last Updated

    This line's too long.

    chipx86chipx86

    This one, too.

    chipx86chipx86
    chipx86
    1. 
        
    2. Show all issues

      This line's too long.

    3. Show all issues

      This one, too.

    4. 
        
    david
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (e1ec70e)