Fix problems when a user closes their own issues requiring verification.

Review Request #9447 — Created Dec. 18, 2017 and submitted

Information

Review Board
release-3.0.x
446d60f...

Reviewers

This change makes it so that users who click "Fixed" (or "Drop") on
issues that they created will transition the issue state directly to
closed, even if the issue had been set to require verification. As it
currently exists, the issue would transition to waiting for
verification, which was unexpected. This also fixes up an issue where a
user object was compared to a pk.

  • Ran unit tests.
  • Exercised the test case listed in the bug.
Description From Last Updated

I feel like the name might need a small adjustment. Maybe isAuthorLoggedInUser? Not a major change, but clarifies "is the …

chipx86chipx86
chipx86
  1. 
      
  2. I feel like the name might need a small adjustment. Maybe isAuthorLoggedInUser? Not a major change, but clarifies "is the author of this currently logged in (somewhere)" to be "is the author of this the current logged in user?" What do you think?

    1. Changing it to just return the author's username, which is pretty self-explanatory, and then we can compare that elsewhere.

  3. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (9526405)
Loading...