Summary

Add legacy attributes on ReviewablePageView for extensions.

Review Request #9438 — Created Dec. 14, 2017 and submitted Dec. 19, 2017, 3:12 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

c16a300...

Reviewers

Groups

reviewboard

People

Description

The view/model cleanup for the reviewable pages removed some attributes
needed by extensions. The reviewRequest attribute was previously
fixed, but the pendingReview attribute remained broken. This adds this
attribute back, and listens for any changes on the model in order to
update the view (which currently does not happen, but this might change
for pending reviews as things become more dynamic).

Testing Done

Tested that Power Pack and rbstopwatch both worked. Previously, rbstopwatch
was broken.

Unit tests pass.

Issues

Description	From	Last Updated
Probably a bit better as: ```javascript ['reviewRequest', 'pendingReview'].forEach(attrName => { ... });	david	Dec. 19, 2017, 2:49 p.m.
I'm not sure this comment actually adds anything. That line of code is pretty self explanatory.	david	Dec. 19, 2017, 11:02 a.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js (Diff revision 1)

The issue has been resolved. Show all issues

Probably a bit better as:
```javascript

['reviewRequest', 'pendingReview'].forEach(attrName => {

    ...

});

reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js (Diff revision 1)

The issue has been dropped. Show all issues

I'm not sure this comment actually adds anything. That line of code is pretty self explanatory.

chipx86 Dec. 14, 2017, 5:11 p.m.

I was trying to separate sections of code (this was before the _.each() loop). However, I think it's worth adding if you don't know what that class does. At least, I don't think it hurts.

david Dec. 19, 2017, 11:02 a.m.
```
Very well.
```

Change Summary:

Switched from _.each() to Array.forEach().

Commit:

2b28bae19d488cf59b9321786459d9b31ef21aca

c16a30067694aeb2a6bae1d844ee2868482375c4

Diff:

Revision 2 (+15 -3)

Show changes

reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (02b03f8)