flake8
passed.
JSHint
passed.
Touchscreen fixes for RevisionSelectorView
Review Request #9430 — Created Dec. 9, 2017 and discarded
The revision selector view lacked event handlers for touchscreen versions of
mousedown,mouseup, andmousemove
(touchstart,touchend,touchmove, respectively), and required a bit
more padding in between handles for use on mobile devices.This patch (presumably) fixes those issues.
Created a test suite for the Revision Selector View, but only contains
one test for thetouchstartevent as other event handlers proved too
difficult to test. The events that were beyond the authors ability
to test automatically were tested manually.
| Description | From | Last Updated |
|---|---|---|
|
Remaining issues: Requires automated testing for touchend and touchmove events. Overriding the prototypes for the corresponding event handlers in the … |
TB tbrockma |
TB
-
-
Remaining issues:
Requires automated testing for touchend and touchmove events. Overriding the prototypes for the corresponding event handlers in the RevisionSelectorView failed on tests asserting that they were called. This might be related to the listeners being dynamically created after hearing
touchstart/click.Moreover, while the revision selector now works on mobile devices, as you can see in
, there is a finite amount of room available before the revision selector will begin to overflow to the next line. This indicates that it might be necessary in the future to create a different widget to handle changing revisions on mobile devices that is able to accomodate a wider range of revisions.
