Summary

Fix the Review.objects._query method when querying the current user.

Review Request #9411 — Created Nov. 30, 2017 and submitted Dec. 4, 2017, 2:56 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

e77b6ff...

Reviewers

Groups

reviewboard

People

Description

The query returned by Review.objects.from_user() was behaving
strangely when called with the currently logged-in user, because it was
OR-ing in an additional query on top of the ones that are already done
(so that it additionally included reviews that were replies). This is
not what people expect from this query, which is used only in the
"Reviews" list on the user page and in a couple extensions.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
F821 undefined name 'include_own'	reviewbot	Dec. 1, 2017, 9:02 a.m.

flake8 passed.

JSHint passed.

Summary:

Fix the Review.objects.from_user query for "third party" views.

Fix the Review.objects._query method when querying the current user.

Description:

		The query returned by `Review.objects.from_user()` was behaving
		strangely when called with the currently logged-in user, because it was
		OR-ing in an additional query on top of the ones that are already done
~		(so that it additionally included reviews that were replies or drafts).
~		This is rarely what people expect from this query, which is used only in
~		the "Reviews" list on the user page and in a couple extensions.
	~	(so that it additionally included reviews that were replies). This is
	~	not what people expect from this query, which is used only in the
	~	"Reviews" list on the user page and in a couple extensions.
-
-		This change adds an extra parameter to `_query` to preserve the existing
-		behavior, but then makes sure that calls to `from_user` return what's
-		more likely to be expected.