flake8
passed.
JSHint
passed.
Review Request #9404 — Created Nov. 27, 2017 and submitted
The Avatar Settings form's
clean_default_service()
method attempted to
access cleaned data for other fields. Whether or not this works depends
on the order in which theForm
class attempts to clean fields, and
broke in some manual testing I was performing, raisingKeyErrors
.This switches this method to be a
clean()
method, allowing it to
operate on cleaned data from multiple fields and ensuring that saving
never breaks.
Saved the form many times without hitting these crashes.
Unit tests pass.