Summary

Fix a handful of unit test failures.

Review Request #9371 — Created Nov. 14, 2017 and submitted Nov. 23, 2017, 8:13 p.m.

Information

Owner

david

Repository

RBTools

Branch

release-0.7.x

Bugs

Depends On

Commit

08d277d...

Reviewers

Groups

rbtools

People

Description

The new kgb is a lot more strict when it comes to kwargs. This change
fixes up some test failures that were introduced by upgrading to it.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Can you bump the kgb dependency in dev-requirements.txt?	chipx86	Nov. 16, 2017, 10:27 p.m.
You shoudl just be able to add **kwargs instead here. It just needs to be compatible (basically, all keyword arguments …	chipx86	Nov. 16, 2017, 10:32 p.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

Can you bump the kgb dependency in dev-requirements.txt?

rbtools/clients/tests/test_svn.py (Diff revision 1)

The issue has been resolved. Show all issues

You shoudl just be able to add **kwargs instead here. It just needs to be compatible (basically, all keyword arguments in the original function are forwarded now by name to the new function -- *args, **kwargs can still catch any extra arguments here).

Commit:

f3e7343a0b8a0ba6fa2185b218d140f3262fa1db

08d277d3095a94b1933d9790ff49a515fb110d71

Diff:

Revision 2 (+24 -21)

Show changes

	dev-requirements.txt
	rbtools/clients/git.py
	rbtools/clients/tests/test_git.py
	rbtools/clients/tests/test_svn.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.7.x (7a2c691)