This fixes one serious bug (in some browsers) where a missing variable

definition in the upload diff view was causing a javascript crash,

breaking the Update -> Update Diff action. While I was fixing that up, I

decided to fix up the other things that jshint complained about.

Verified that Update -> Update Diff now worked as expected in strict

  mode.
Ran jshint.
Ran js-tests.