4604: Update diff doesn't work on review

theBoss
4564

What version are you running?

3.0RC1

What's the URL of the page containing the problem?

Intranet, not accessible outside of Nokia

What steps will reproduce the problem?

  1. Create review
  2. Click Update->Update diff

What is the expected output? What do you see instead?

Expected: Dialog for diff update should appear.
Actuall: Nothing happens, just error in consol log
Uncaught ReferenceError: selectParentDiffText is not defined
at render (reviews.min.d5ed5d3e28ec.js:7)
at render (reviews.min.d5ed5d3e28ec.js:7)
at r._onUpdateDiffClicked (reviews.min.d5ed5d3e28ec.js:6)
at HTMLAnchorElement.dispatch (jquery-1.11.1.min.8101d596b2b8.js:3)
at HTMLAnchorElement.r.handle (jquery-1.11.1.min.8101d596b2b8.js:3)

What operating system are you using? What browser?

Arch Linux, Vivaldi 1.11.917.43, Firefox 55.03

Please provide any additional information below.

This is rather critucal issue as basic Web Interface element is not working.

david
#1 david
  • -New
    +PendingReview
david
#2 david

Fixed in release-3.0.x (73ed3c3). This will ship in 3.0 final. Thanks!

  • -PendingReview
    +Fixed