Fix some errors and warnings in JavaScript.

Review Request #9356 - Created Nov. 9, 2017 and submitted

David Trowbridge
Review Board
release-3.0.x
4604
ade520a...
reviewboard

This fixes one serious bug (in some browsers) where a missing variable
definition in the upload diff view was causing a javascript crash,
breaking the Update -> Update Diff action. While I was fixing that up, I
decided to fix up the other things that jshint complained about.

  • Verified that Update -> Update Diff now worked as expected in strict
    mode.
  • Ran jshint.
  • Ran js-tests.
Christian Hammond
  1. Ship It!
  2. 
      
David Trowbridge
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (73ed3c3)

Loading...