Fix a crash and layout problem when editing the Testing Done field.

Review Request #9340 — Created Oct. 31, 2017 and submitted

Information

Review Board
release-3.0.x
1da0b9e...

Reviewers

The recent work to port $.fn.inlineEditor to Backbone missed a
variable update (_$buttons to $buttons) in the review request layout
code, which could result in a crash and leave the layout in a bad state.
This would manifest as a short text field when starting to edit, and
file attachments overlaying text field when completing the editing.

To reproduce this, the last text field needed to have its height
expanded to the height of the fields on the side when not in edit mode.
This was easily the case if the Description field was empty or only
contained a line or two, and the Testing Done field was being filled
with many lines of content.

The variable fix avoids the crash, allowing the layout code to complete
successfully.

Reproduced both the short textfield bug and the overlapping file
attachments bug, and saw the crash in both cases. Verified that this
fixed both.

david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.0.x (9e22cc8)