• 
      

    Make General Comment creation in the UI more clear.

    Review Request #9313 — Created Oct. 23, 2017 and submitted

    Information

    Review Board
    release-3.0.x
    cacc383...

    Reviewers

    The introduction of General Comments added a button to the Review Dialog
    and to the review request's action bar saying "Add Comment." This label
    doesn't make clear that it's a General Comment being added, and could
    easily be confused as the way one is supposed to do code review
    (similarly to how some people have been confused in the past trying to
    put their review in the Header field).

    This change renames these both to "Add General Comment," helping to
    clarify just a bit. It's a bit longer, but there's plenty of room on the
    review request's action bar and in the Review Dialog for this, and it
    should hold us over until the new review UI is ready.

    It also moves the button in the Review Dialog over to the left of the
    dialog, separating it from buttons that impact the overall
    review/dialog.

    Tested that both of these buttons still work.

    Tested the Review Dialog's button placement in desktop and mobile modes.


    Description From Last Updated

    There's a number of places in the docs that reference "Add Comment". Those should be changed along with this.

    daviddavid
    david
    1. 
        
    2. Show all issues

      There's a number of places in the docs that reference "Add Comment". Those should be changed along with this.

      1. I'm doing some larger-scale doc work involving General Comments, changes to the Review Dialog, and others. I have these references changed in the docs already.

      2. Sorry, I take that back. I just added new references to this and changed some in-tree docs I wrote from "Add Comment" to "General Comment". I don't see "Add Comment" in the upstream docs. Docs on General Comments were never written.

      3. OK. I do get a bunch of hits when I search for "Add Comment" but it looks like most of those should be changed to "Reply".

      4. Yeah. There's a few that are for file attachments, too. I'll change the Reply ones.

    3. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (f4df880)