• 
      

    Improve performance when building strings in template tags.

    Review Request #9287 — Created Oct. 18, 2017 and submitted — Latest diff uploaded

    Information

    Review Board
    release-3.0.x
    1df7f43...

    Reviewers

    We had several template tags that were building strings through string
    concatenation, which in Python isn't particularly fast or
    memory-efficient when working with lots of data. The most notable of
    these is when highlighting changed regions in diffs.

    This change switches these to building lists of strings and joining them
    for a final result, which should provide a small performance benefit.

    Unit tests pass.

    Manually tested that diffs did not break from this change.