Call e-mail hooks that have changed in a backwards compatible manner
Review Request #9250 — Created Oct. 6, 2017 and submitted — Latest diff uploaded
The
ReviewEmailHook
updated in 3.0b2 with a new argument
(to_submitter_only
). The previous hooks did not accept**kwargs
, so
calling any existing hook with this new argument will cause an Exception
(and the e-mail will not send). We are now very careful about only
passing in these new arguments when the hook supports them. Otherwise,
we will omit the argument and emit a warning that the hook should accept
**kwargs
.All hook base classes have been updated to accept
**kwargs
.
Tested with an extension that defined a ReviewEmailHook that did not
acceptto_submitter_only
. The warning was emitted and the hook did
not cause an exception